Repository navigation
Cancel a pending streaming handshake on disconnect - #311
Open
codebanditssss wants to merge 1 commit into
Open
codebanditssss wants to merge 1 commit into
codebanditssss wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #309.
connect()now reserves the single-use connection before the handshake's first await and records its task.disconnect()cancels and awaits a pending connect before tearing down. A cancelled connect closes the socket and HTTP client and re-raisesCancelledError. The existing handshake and retry code moves unchanged into_connect(). Disconnect skips the cancel when it runs inside the connect task itself, for example from a handshake error callback.Tests
tests/unit/test_streaming_connect_lifecycle.pyuses a real local WebSocket server whose upgrade response is held until disconnect returns. It covers disconnect with and withoutterminate, concurrent connects, reuse after a cancelled connect, a normal connection, and repeated disconnect.open_sockets=1after disconnect). Fixed: 5 passed (open_sockets=0).async_client.pyreports the same 15 diagnostics as the unchanged upstream file.Bumps the version to 1.10.15 so it doesn't collide with #307 and the #308 fix.